Skip to content

fix(annotations): Check for invalid sender requirements #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(annotations): Check for invalid sender requirements #781

wants to merge 1 commit into from

Conversation

@jpenilla
Copy link
Member

@jpenilla jpenilla commented Oct 26, 2024

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 26, 2024

Test Results

 88 files  ±0   88 suites  ±0   14s ⏱️ -1s
430 tests +1  430 ✅ +1  0 💤 ±0  0 ❌ ±0 
475 runs  +1  475 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 2d0a7dc. ± Comparison against base commit 3c83f9a.

This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both. 
org.incendo.cloud.annotations.feature.RequiredSenderDeductionTest ‑ testCorrectSender()
org.incendo.cloud.annotations.feature.RequiredSenderDeductionTest ‑ testIncorrectSender()

org.incendo.cloud.annotations.feature.RequiredSenderTest ‑ testCorrectSender()
org.incendo.cloud.annotations.feature.RequiredSenderTest ‑ testIncorrectSender()
org.incendo.cloud.annotations.feature.RequiredSenderTest ‑ testInvalidRequirement()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Citymonstret Citymonstret Citymonstret approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpenilla @Citymonstret